Skip to content

Initial SAP etd release#11722

Merged
v-atulyadav merged 27 commits intoAzure:masterfrom
MartinPankraz:add-sapetd
Feb 20, 2025
Merged

Initial SAP etd release#11722
v-atulyadav merged 27 commits intoAzure:masterfrom
MartinPankraz:add-sapetd

Conversation

@MartinPankraz
Copy link
Contributor

@MartinPankraz MartinPankraz commented Jan 27, 2025

Required items, please complete

Change(s):

  • Release of SAP ETD solution

Reason for Change(s):

  • Initial release

@v-prasadboke v-prasadboke self-assigned this Jan 28, 2025
@v-prasadboke v-prasadboke added the New Solution For new Solutions which are new to Microsoft Sentinel label Jan 28, 2025
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Jan 28, 2025

Hello @MartinPankraz, Please package the solution again with version 3.0.0

@MartinPankraz MartinPankraz marked this pull request as ready for review January 28, 2025 14:09
@MartinPankraz MartinPankraz requested review from a team as code owners January 28, 2025 14:09
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Feb 3, 2025

Hello @MartinPankraz, Looks like you accidentally removed the Connector and Detection file. Can you please add those back

@MartinPankraz
Copy link
Contributor Author

MartinPankraz commented Feb 3, 2025

Hello @MartinPankraz, Looks like you accidentally removed the Connector and Detection file. Can you please add those back

Hey @v-prasadboke the solution is complete on the mainTemplate.json only (connector and detections). The other folders and files are empty. Dropped them for clarity.

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Feb 6, 2025

Hello @MartinPankraz,

These files are required in the Solution folder and cannot be removed. They are necessary for future use and may be essential as the solution evolves or for upcoming integrations.

@MartinPankraz
Copy link
Contributor Author

MartinPankraz commented Feb 6, 2025

@v-prasadboke changes done as per your request

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Feb 18, 2025

image

Connector Connected Successfully

@v-atulyadav v-atulyadav merged commit 88d3efb into Azure:master Feb 20, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

+1 more reviewer

@v-prasadboke v-prasadboke v-prasadboke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-prasadboke v-prasadboke

Labels

New Solution For new Solutions which are new to Microsoft Sentinel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinPankraz @v-prasadboke @v-atulyadav